This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Enable signature verification in background task #10946
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bkchr Can someone from parity give me feedback on this PR please? We still want to integrate signature verification as a background task :) |
|
@bkchr can we get a review/feedback on this please ? |
bkchr
reviewed
Apr 13, 2022
There was a problem hiding this comment.
Sorry sorry for all the delay.
In general it looks okay. I added some comments to improve the implementation. In general I think that frame-executive could be less code copying when you make the "important" functions a little bit more generic. I think you will be able to manage this :)
We will also need some tests that ensure everything is working. Maybe the already existing tests are enough in frame-executive and we just need to add some step to the CI to enable the feature and run the frame-executive tests.
You should be able to copy this job here:
Lines 371 to 387 in 1f4cd99
And make it work for that :)
Comment on lines
+828
to
+829
| /// Check self in a background tas, given an instance of Context. | ||
| fn background_check( |
There was a problem hiding this comment.
Suggested change
| /// Check self in a background tas, given an instance of Context. | |
| fn background_check( | |
| /// Check `self` using the given `context`. | |
| /// | |
| /// Any signature will be checked using [`BackgroundVerify`]. | |
| /// | |
| /// # Security | |
| /// | |
| /// It is required that this is called in a [`SignatureBatching`](crate::SignatureBatching) context. | |
| fn batch_verification_check( |
primitives/runtime/src/traits.rs
Outdated
Comment on lines
169
to
180
| /// Register a signature for background verification. | ||
| /// | ||
| /// This requires that background verification is enabled by doing XYZ. | ||
| /// | ||
| /// Returns `true` when the signature was successfully registered for background verification | ||
| /// or if background verification is not enabled the signature could be verified successfully | ||
| /// immediately. | ||
| /// | ||
| /// # Warning | ||
| /// | ||
| /// This requires that the background verification is finished by calling finalize_verify to | ||
| /// check the result of all submitted signature verifications. |
There was a problem hiding this comment.
Suggested change
| /// Register a signature for background verification. | |
| /// | |
| /// This requires that background verification is enabled by doing XYZ. | |
| /// | |
| /// Returns `true` when the signature was successfully registered for background verification | |
| /// or if background verification is not enabled the signature could be verified successfully | |
| /// immediately. | |
| /// | |
| /// # Warning | |
| /// | |
| /// This requires that the background verification is finished by calling finalize_verify to | |
| /// check the result of all submitted signature verifications. | |
| /// Register a signature for background verification. | |
| /// | |
| /// Returns `true` when the signature was successfully registered for background verification | |
| /// or if background verification is not enabled the signature could be verified successfully | |
| /// immediately. | |
| /// | |
| /// # Security | |
| /// | |
| /// It is required that this is called in a [`SignatureBatching`](crate::SignatureBatching) context. |
The SignatureBatching should then be renamed.
kianenigma
reviewed
Apr 13, 2022
There was a problem hiding this comment.
Not sure if it would be valuable testing, but this does seem like something that we can test with follow-chain command. See: https://paritytech.github.io/substrate/master/try_runtime_cli/enum.Command.html#variant.FollowChain
What you would need to do is create a polkadot binary that contains this PR and is otherwise the same as whatever is the live network, then you can run this command and let it run the real polkadot blocks inside a test env that contains batch signature verification.
bkchr
reviewed
Apr 19, 2022
@bkchr what new name do you suggest ? |
IDK. Maybe |
|
@bkchr This PR is ready for a final review :) @kianenigma I ran try-runtime follow-chain on a polkadot fork that include this PR, and it seems to work well: |
|
@bkchr This PR is ready and the CI is green, can you do a final review ? |
|
It stops working for larger blocks, when i try the With 100 extrinsics per block it works fine: # On branch PureStake:elois-background-sig-verif
cargo r --release --bin substrate --features background-signature-verification -- benchmark extrinsic --pallet system --extrinsic remark --dev --max-ext-per-block 100
Running 10 warmups...
Executing block 100 times
Building block, this takes some time...
Extrinsics per block: 100
Running 10 warmups...
Executing block 100 times
Executing a system::remark extrinsic takes[ns]:
Total: 5699353
Min: 55747, Max: 58498
Average: 56993, Median: 56988, Stddev: 402.85
Percentiles 99th, 95th, 75th: 57993, 57578, 57250But with 1000 it panics: It warns |
|
Thank you @ggwpez for your tests :) I ran the same commands as you and I got the same error. I admit I haven't understood everything yet, this is a part of the code I haven't written and haven't touched yet. hope that #12147 will indeed solve the problem. |
|
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/background-signature-verification/132/1 |
|
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
A5-stale
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring back signature batch verification but with the new name background verification.
Indeed, batch verification - in the cryptographic sense - is a different feature, and only exists for certain types of signatures.
Batch verification is currently only implemented for signatures of type sr25519. For the other types of signatures (ed25519 and ecdsa), each signature is verified alone but in a background task.
Some questions about the design:
Added an optimization suggested by @crystalin: in case the first extrinsics are particularly long to run, the background tasks that check the signatures will do nothing for a while, which is suboptimal.
It is more optimal to spawn all the signatures to be checked in the background before starting to run the extrinsics.
Closes paritytech/polkadot-sdk#351